CI/GnuComment: enhance PR commenting logic to update existing comments#11763
Merged
sylvestre merged 2 commits intouutils:mainfrom Apr 13, 2026
Merged
CI/GnuComment: enhance PR commenting logic to update existing comments#11763sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
Contributor
Author
|
@sylvestre How can we test this? |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
let's see what happens |
Contributor
|
It looks like there is a bug (see https://github.com/uutils/coreutils/actions/runs/24334867494/job/71049096034#step:4:44): |
Contributor
Author
I don't understand why this fails now, but let's add something like: if (!fs.existsSync('./result.txt') || !fs.existsSync('./NR')) {
console.log('Files in workspace:', fs.readdirSync('.'));
throw new Error('Missing result.txt or NR from artifact');
} |
Contributor
Author
Contributor
Author
|
Looks like it's working now: #11330 (comment) |
Contributor
Contributor
Author
|
@sylvestre This is what I'm seeing for #11922 (comment): Comment created: 2026-04-20T17:25:03Z So it appears the action is working correctly. |
Contributor
|
oh, my bad, i thought github updated the initial date too |
Contributor
|
maybe we can do it? |
Contributor
Author
|
The alternative would be to delete the comment and recreate it, but one of the goals of this change was to minimize notifications. I think the current behavior is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11761
Summary
Update GNU testsuite comment workflow to edit a single bot comment instead of creating new ones on each run.
Key change
<!-- gnu-comment-bot -->) to identify bot-generated comments.